feat: remove checkpoint_on_startup #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killme2008
force-pushed
the
feature/remove-checkpoint-on-startup
branch
from
a5a8df3 to
2c9bc45
Compare
killme2008
force-pushed
the
feature/remove-checkpoint-on-startup
branch
from
2c9bc45 to
3280d50
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2228 +/- ##
===========================================
+ Coverage 84.53% 84.64% +0.11%
===========================================
Files 701 703 +2
Lines 113262 114381 +1119
===========================================
+ Hits 95748 96822 +1074
- Misses 17514 17559 +45 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
feat: update flushed manifest version when it is larger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
checkpoint_on_startup, it's an outdated option. When introducing the checkpoint feature for manifest, we want to trigger a checkpoint at startup.Checklist
Refer to a related PR or issue link (optional)